Attempt to fix issue 332427 by deleting LoggingImpl in CastEnvironment on the main thread instead o…

Attempt to fix issue 332427 by deleting LoggingImpl in CastEnvironment on the main thread instead of the last thread holding on reference to it by doing PostTask with the main thread task runner. Also re-enable CastStreamingApiTest.Basics as this patch should fix the problem.

BUG=332427
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244075

[imcheng, 2014-01-09 02:34:25]

I attempted to use RefCountedDeleteOnMessageLoop prior to this approach, though
it seems they are discouraging the use of MessageLoopProxy (i.e. use TaskRunner
interfaces) so I can't even pass presubmit with that approach. That said it
looks like it's possible to change RefCountedDeleteOnMessageLoop to take a
SingleThreadTaskRunner, but looks like more trouble than it's worth as callers
of RefCountedDeleteOnMessageLoop and fake_task_runner will have to change. So I
just went with a simple fix, let me know what you think.

Thanks,
Derek

[Alpha Left Google, 2014-01-09 02:38:57]

Okay. LGTM.

[imcheng, 2014-01-09 02:50:31]

Forgot to re-enable the test - did that just now and running through trybots.

[commit-bot: I haz the power, 2014-01-09 09:23:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/130573002/180001

[commit-bot: I haz the power, 2014-01-09 09:41:58]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-09 22:01:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/130573002/310001

[commit-bot: I haz the power, 2014-01-09 22:27:52]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[imcheng, 2014-01-09 22:40:56]

+kalman for chrome/browser/extensions/cast_streaming_apitest.cc.

[not at google - send to devlin, 2014-01-09 23:06:51]

lgtm

[commit-bot: I haz the power, 2014-01-09 23:38:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/130573002/310001

[commit-bot: I haz the power, 2014-01-10 01:23:14]

Retried try job too often on linux_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2014-01-10 01:43:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/130573002/310001

[commit-bot: I haz the power, 2014-01-10 03:48:55]

Change committed as 244075