Make the NTP apps page respect the enable hosted apps in windows flag.

Make the NTP apps page respect the enable hosted apps in windows flag.

https://codereview.chromium.org/1300763002/ adds a new flag,
--[enable|disable]-hosted-apps-in-windows on Mac. This flag controls
whether hosted apps are allowed to open in windows independently of
whether the new bookmark app system is enabled.

This CL amends the logic in the NTP apps page to correctly display
the launch options for apps for all permutations of
--[enable|disable]-new-bookmark-apps and
--[enable|disable]-hosted-apps-in-windows. This means that as the
default values change for these options, the NTP will behave
appropriately.

BUG=517682, 520361
Committed: https://crrev.com/6710ac59fd1f094d55f734ad9a1eb884bce5fa71
Cr-Commit-Position: refs/heads/master@{#344979}

[dominickn, 2015-08-20 01:21:46]

dominickn@chromium.org changed reviewers:
+ dbeam@chromium.org

[dominickn, 2015-08-20 01:21:46]

dbeam: please have a look - the CL adding the new flag is landing now. Thanks!

[Dan Beam, 2015-08-20 18:25:57]

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/apps_page.js (right):

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/apps_page.js:153: hasLaunchType = hasLaunchType ||
!launchTypeButton.hidden;
if (!launchTypeButton.hidden) hasLaunchType = true;

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:485:
load_time_data.SetBoolean("hostedAppsInWindowsEnabled",
nit: hostedAppsInWindowsEnabled -> canHostedAppsOpenInWindows

[dominickn, 2015-08-20 22:07:44]

Thanks!

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/apps_page.js (right):

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/apps_page.js:153: hasLaunchType = hasLaunchType ||
!launchTypeButton.hidden;
On 2015/08/20 18:25:57, Dan Beam wrote:
> if (!launchTypeButton.hidden) hasLaunchType = true;

Done.

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/1305653002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:485:
load_time_data.SetBoolean("hostedAppsInWindowsEnabled",
On 2015/08/20 18:25:57, Dan Beam wrote:
> nit: hostedAppsInWindowsEnabled -> canHostedAppsOpenInWindows

Done.

[Dan Beam, 2015-08-22 06:36:21]

lgtm

https://codereview.chromium.org/1305653002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/1305653002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:483: bool
hosted_apps_in_windows_enabled =
nit: just inline this rather than creating a copy of the method name that's easy
to forget to update ;)

[dominickn, 2015-08-22 10:37:53]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2015-08-22 10:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1305653002/#ps60001
(title: "Addressing reviewer feedback")

[commit-bot: I haz the power, 2015-08-22 10:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305653002/60001

[commit-bot: I haz the power, 2015-08-22 12:11:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-22 12:13:11]

Patchset 4 (id:??) landed as
https://crrev.com/6710ac59fd1f094d55f734ad9a1eb884bce5fa71
Cr-Commit-Position: refs/heads/master@{#344979}