Issue 130563014: Get rid of the *Byte types used for (de)serializing to SVGPathByteStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130563014: Get rid of the *Byte types used for (de)serializing to SVGPathByteStream (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, pdr, Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of the *Byte types used for (de)serializing to SVGPathByteStream Use a single ByteType<T> instead. Additionally clean up SVGPathByteStream a bit by delegating two more methods {isEmpty(), append(SVGPathByteStream*)} to the wrapped WTF::Vector. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166481

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -68 lines)			Patch
M	Source/core/svg/SVGPathByteStream.h	View	2 chunks	+7 lines, -21 lines	0 comments	Download
M	Source/core/svg/SVGPathByteStreamBuilder.h	View	1 chunk	+11 lines, -27 lines	0 comments	Download
M	Source/core/svg/SVGPathByteStreamSource.h	View	2 chunks	+8 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

On 2014/02/04 18:50:41, Stephen Chenney wrote: > LGTM. Do we still use DataIterator? Yes, it ...

6 years, 10 months ago (2014-02-05 08:23:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/130563014/1

6 years, 10 months ago (2014-02-05 08:23:43 UTC) #5

Message was sent while issue was closed.

Change committed as 166481

Expand Messages | Collapse Messages