base/json/json_string_value_serializer.cc - Issue 130563010: Invalid JSON output when BinaryValue suppressed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_string_value_serializer.cc

Issue 130563010: Invalid JSON output when BinaryValue suppressed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: NOTREACHED() & return false at end of function. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_string_value_serializer.cc

diff --git a/base/json/json_string_value_serializer.cc b/base/json/json_string_value_serializer.cc

index 7611fbeed654229cc45bdd0776fe4cb17c180831..59f030dff2fd52418333218bcaeb3868295994be 100644

--- a/base/json/json_string_value_serializer.cc

+++ b/base/json/json_string_value_serializer.cc

@@ -32,8 +32,7 @@ bool JSONStringValueSerializer::SerializeInternal(const Value& root,

if (pretty_print_)

options |= base::JSONWriter::OPTIONS_PRETTY_PRINT;

- base::JSONWriter::WriteWithOptions(&root, options, json_string_);

- return true;

+ return base::JSONWriter::WriteWithOptions(&root, options, json_string_);

}

Value* JSONStringValueSerializer::Deserialize(int* error_code,

« no previous file with comments | « no previous file | base/json/json_writer.h » ('j') | no next file with comments »