Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 130563009: Use IfBuilder instead of handcrafted basic blocks in GenerateSetValueOf(). (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Use IfBuilder instead of handcrafted basic blocks in GenerateSetValueOf(). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M src/hydrogen.cc View 1 chunk +16 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Trivial cleanup. PTAL.
6 years, 10 months ago (2014-01-29 07:40:26 UTC) #1
Sven Panne
lgtm
6 years, 10 months ago (2014-01-29 09:32:41 UTC) #2
Benedikt Meurer
6 years, 10 months ago (2014-01-29 09:59:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698