Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 130563003: Change all other AutofillDialogView methods with a const DetailInput& as a param (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 787694ab8b473d3fcdb259d52eb5fadb113e7002..7f857a79dab2454b7870c369f053c9a934fb57ef 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -1443,12 +1443,12 @@ void AutofillDialogViews::CancelForTesting() {
}
base::string16 AutofillDialogViews::GetTextContentsOfInput(
- const DetailInput& input) {
- views::Textfield* textfield = TextfieldForType(input.type);
+ ServerFieldType type) {
+ views::Textfield* textfield = TextfieldForType(type);
if (textfield)
return textfield->text();
- views::Combobox* combobox = ComboboxForType(input.type);
+ views::Combobox* combobox = ComboboxForType(type);
if (combobox)
return combobox->model()->GetItemAt(combobox->selected_index());
@@ -1457,17 +1457,17 @@ base::string16 AutofillDialogViews::GetTextContentsOfInput(
}
void AutofillDialogViews::SetTextContentsOfInput(
- const DetailInput& input,
+ ServerFieldType type,
const base::string16& contents) {
- views::Textfield* textfield = TextfieldForType(input.type);
+ views::Textfield* textfield = TextfieldForType(type);
if (textfield) {
textfield->SetText(contents);
return;
}
- views::Combobox* combobox = ComboboxForType(input.type);
+ views::Combobox* combobox = ComboboxForType(type);
if (combobox) {
- SelectComboboxValueOrSetToDefault(combobox, input.initial_value);
+ SelectComboboxValueOrSetToDefault(combobox, contents);
return;
}
@@ -1481,8 +1481,8 @@ void AutofillDialogViews::SetTextContentsOfSuggestionInput(
SetText(text);
}
-void AutofillDialogViews::ActivateInput(const DetailInput& input) {
- TextfieldEditedOrActivated(TextfieldForType(input.type), false);
+void AutofillDialogViews::ActivateInput(ServerFieldType type) {
+ TextfieldEditedOrActivated(TextfieldForType(type), false);
}
gfx::Size AutofillDialogViews::GetSize() const {

Powered by Google App Engine
This is Rietveld 408576698