Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2939)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm

Issue 130563003: Change all other AutofillDialogView methods with a const DetailInput& as a param (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
index 716bb9a9a96f31fda47b470f9d6d47416af522df..6e66fed0a741a3b896c6fe197d883114e3b38a0e 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm
@@ -466,11 +466,11 @@ const CGFloat kMinimumContentsHeight = 101;
@implementation AutofillDialogWindowController (TestableAutofillDialogView)
- (void)setTextContents:(NSString*)text
- forInput:(const autofill::DetailInput&)input {
+ forType:(autofill::ServerFieldType)type {
for (size_t i = autofill::SECTION_MIN; i <= autofill::SECTION_MAX; ++i) {
autofill::DialogSection section = static_cast<autofill::DialogSection>(i);
// TODO(groby): Need to find the section for an input directly - wasteful.
- [[mainContainer_ sectionForId:section] setFieldValue:text forInput:input];
+ [[mainContainer_ sectionForId:section] setFieldValue:text forType:type];
}
}
@@ -479,10 +479,10 @@ const CGFloat kMinimumContentsHeight = 101;
[[mainContainer_ sectionForId:section] setSuggestionFieldValue:text];
}
-- (void)activateFieldForInput:(const autofill::DetailInput&)input {
+- (void)activateFieldForType:(autofill::ServerFieldType)type {
for (size_t i = autofill::SECTION_MIN; i <= autofill::SECTION_MAX; ++i) {
autofill::DialogSection section = static_cast<autofill::DialogSection>(i);
- [[mainContainer_ sectionForId:section] activateFieldForInput:input];
+ [[mainContainer_ sectionForId:section] activateFieldForType:type];
}
}

Powered by Google App Engine
This is Rietveld 408576698