Change all other AutofillDialogView methods with a const DetailInput& as a param

Change all other AutofillDialogView methods with a const DetailInput& as a param
to a ServerFieldType.

This is necessary as some browser tests started failing when country changes
caused DetailInputs for a section to be rebuilt even with the same type and
contents.

R=estade@chromium.org,groby@chromium.org
BUG=331544
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243992

[Dan Beam, 2014-01-09 04:31:33]

https://codereview.chromium.org/130563003/diff/30001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(left):

https://codereview.chromium.org/130563003/diff/30001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:584:
&inputs[i] == &triggering_input || users_input.empty() ?
^ stuff like this was the general issue

[Evan Stade, 2014-01-09 19:12:41]

lgtm

[groby-ooo-7-16, 2014-01-09 19:35:21]

I suppose ControllerImpl is next?

Cocoa LGTM unless you can address the comment.

https://chromiumcodereview.appspot.com/130563003/diff/240001/chrome/browser/u...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://chromiumcodereview.appspot.com/130563003/diff/240001/chrome/browser/u...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:156: for (size_t i =
SECTION_MIN; i <= SECTION_MAX; ++i) {
We don't have a way currently to get DialogSection from ServerFieldType, do we?
Because that'd save a whole lot of iteratin' here.

[Dan Beam, 2014-01-09 19:44:21]

https://chromiumcodereview.appspot.com/130563003/diff/240001/chrome/browser/u...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://chromiumcodereview.appspot.com/130563003/diff/240001/chrome/browser/u...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:156: for (size_t i =
SECTION_MIN; i <= SECTION_MAX; ++i) {
On 2014/01/09 19:35:21, groby wrote:
> We don't have a way currently to get DialogSection from ServerFieldType, do
we?
> Because that'd save a whole lot of iteratin' here.

AutofillType(type).group() would give you a good hint.  views has a map of type
-> {combobox,textarea}.

[commit-bot: I haz the power, 2014-01-09 19:46:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/130563003/240001

[commit-bot: I haz the power, 2014-01-09 22:11:43]

Change committed as 243992