Issue 1305523003: [bindings] Make ScriptValue::v8ValueFor(...) a 'const' method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1305523003: [bindings] Make ScriptValue::v8ValueFor(...) a 'const' method. (Closed)

Created:
5 years, 4 months ago by vivekg_samsung

Modified:
5 years, 4 months ago

Reviewers:
haraken, vivekg

CC:
vivekg, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[bindings] Make ScriptValue::v8ValueFor(...) a 'const' method. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200829

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/bindings/core/v8/ScriptValue.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/bindings/core/v8/ScriptValue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vivekg

PTAL, this will be required for CustomEvent custom bind usage removal tomorrow.

5 years, 4 months ago (2015-08-19 14:33:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305523003/1

5 years, 4 months ago (2015-08-19 14:41:22 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 15:49:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200829

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages