Source/core/fileapi/File.h - Issue 1305463002: Returning const by ref instead of const by value in File::name() api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/File.h

Issue 1305463002: Returning const by ref instead of const by value in File::name() api (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fileapi/File.h

diff --git a/Source/core/fileapi/File.h b/Source/core/fileapi/File.h

index 68ed9ce5325f9d38f16823c846c0992985982b2a..fedb56a33bd3f550a70565e3cfdd536fd013627b 100644

--- a/Source/core/fileapi/File.h

+++ b/Source/core/fileapi/File.h

@@ -122,7 +122,7 @@ public:

void appendTo(BlobData&) const override;

const String& path() const { ASSERT(hasValidFilePath()); return m_path; }

- const String name() const { return m_name; }

+ const String& name() const { return m_name; }

// Getter for the lastModified IDL attribute,

// http://dev.w3.org/2006/webapi/FileAPI/#file-attrs

« no previous file with comments | « no previous file | no next file » | no next file with comments »