Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1305453003: Fix data race in blink::WorkerMessagingProxy::reportException (Closed)

Created:
5 years, 4 months ago by kinuko
Modified:
5 years, 4 months ago
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix data race in blink::WorkerMessagingProxy::reportException Also make it impossible to access WorkerThread::workerGlobalScope on a wrong thread at least from outside the class BUG=520012, 460445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kinuko
Could either of you review?
5 years, 4 months ago (2015-08-19 06:50:19 UTC) #2
hiroshige
lgtm. Thanks for fixing! Tested the case in Issue 460445 ~20 times and didn't see ...
5 years, 4 months ago (2015-08-19 10:33:15 UTC) #3
kinuko
On 2015/08/19 10:33:15, hiroshige (ooo zombie) wrote: > lgtm. Thanks for fixing! > > Tested ...
5 years, 4 months ago (2015-08-19 11:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305453003/1
5 years, 4 months ago (2015-08-19 11:20:16 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 12:27:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200821

Powered by Google App Engine
This is Rietveld 408576698