Add UMA stats for Chromoting connection details.

remoting/webapp/base/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 563 matching lines @@
  * @param {remoting.ClientSession.State} oldState The new state for the session.
  * @param {remoting.ClientSession.State} newState The new state for the session.
  * @private
  */
 remoting.ClientSession.prototype.notifyStateChanges_ =
     function(oldState, newState) {
   /** @type {remoting.Error} */
   var error;
   switch (this.state_) {
     case remoting.ClientSession.State.CONNECTED:
+      chrome.metricsPrivate.recordUserAction(

[kelvinp, 2015/08/20 23:21:23]

I think this will break our unit tests, as chrome.metricsPrivate won't be
defined.  Please add the definition to chrome_mocks.js

Can we group the all the metrics related call into a separate function like
updateMetrics() and call it in setState_() after notifyStateChanges()?

[anandc, 2015/08/21 03:15:42]

I ran ./remoting/tools/run_webapp_unittests.py and all tests passed. Is there
any other tests I should run?

+          'Chromoting.Connections.Connected');
       console.log('Connection established.');
       var connectionInfo = new remoting.ConnectionInfo(
           this.host_, this.credentialsProvider_, this, this.plugin_);
       this.listener_.onConnected(connectionInfo);
       break;
 
     case remoting.ClientSession.State.CONNECTING:
+      chrome.metricsPrivate.recordUserAction(
+          'Chromoting.Connections.Connecting');
       remoting.identity.getEmail().then(function(/** string */ email) {
         console.log('Connecting as ' + email);
       });
       break;
 
     case remoting.ClientSession.State.AUTHENTICATED:
+      chrome.metricsPrivate.recordUserAction(
+          'Chromoting.Connections.Authenticated');
       console.log('Connection authenticated.');
       break;
 
     case remoting.ClientSession.State.INITIALIZING:
       console.log('Connection initializing .');
       break;
 
     case remoting.ClientSession.State.CLOSED:
+      chrome.metricsPrivate.recordUserAction('Chromoting.Connections.Closed');
       console.log('Connection closed.');
       this.listener_.onDisconnected(remoting.Error.none());
       break;
 
     case remoting.ClientSession.State.CONNECTION_CANCELED:
     case remoting.ClientSession.State.FAILED:
       error = this.getError();
       if (!error.isNone()) {
+        chrome.metricsPrivate.recordUserAction('Chromoting.Connections.Failed');
         console.error('Connection failed: ' + error.toString());
       }
       this.listener_.onConnectionFailed(error);
       break;
 
     case remoting.ClientSession.State.CONNECTION_DROPPED:
       error = this.getError();
       console.error('Connection dropped: ' + error.toString());
       this.listener_.onDisconnected(error);
+      chrome.metricsPrivate.recordUserAction('Chromoting.Connections.Dropped');
       break;
 
     default:
       console.error('Unexpected client plugin state: ' + newState);
   }
 };
 
 /**
  * @param {remoting.ClientSession.State} previous
  * @param {remoting.ClientSession.State} current
@@ skipping 28 matching lines @@
  * Enable or disable logging of connection errors due to a host being offline.
  * For example, if attempting a connection using a cached JID, host-offline
  * errors should not be logged because the JID will be refreshed and the
  * connection retried.
  *
  * @param {boolean} enable True to log host-offline errors; false to suppress.
  */
 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
   this.logHostOfflineErrors_ = enable;
 };