Add UMA stats for Chromoting connection details.

remoting/webapp/base/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 548 matching lines @@
     if (this.plugin_.hasCapability(
           remoting.ClientSession.Capability.TOUCH_EVENTS)) {
       this.plugin_.enableTouchEvents(true);
     }
   } else if (this.isFinished()) {
     base.dispose(this.connectedDisposables_);
     this.connectedDisposables_ = null;
   }
 
   this.notifyStateChanges_(oldState, this.state_);
+  if (this.state_ > 1) {

[kelvinp, 2015/08/21 16:29:23]

Currently initializing doesn't fire so this check is not necessary.
And if we ended up firing initializing one day, don't we want to upload that to
UMA as well?

[anandc, 2015/08/21 18:56:56]

Done.

+    // Record state in an UMA histogram if it is after initializing.
+    recordState(this.state_);
+  }
   this.logger_.logClientSessionStateChange(
       this.state_, this.error_, this.xmppErrorCache_.getFirstError());
 };
 
 /**
+ * Records a Chromoting Connection State.
+ * @param {remoting.ClientSession.State} state State identifier.
+ */
+function recordState(state) {
+  var metricDescription = {
+    metricName: 'Chromoting.Connections',
+    type: 'histogram-linear',
+    min: 2,

[kelvinp, 2015/08/21 16:29:24]

Use enum values from remoting.ClientSession.State

[anandc, 2015/08/21 18:56:56]

Done.

+    max: 7,

[kelvinp, 2015/08/21 16:29:23]

The enum range is not consecutive, for example CONNECTION_CANCELED is -3 and
FAILED is 6

[anandc, 2015/08/21 18:56:56]

Thanks. PTAL at the latest implementation.
I considered what you mentioned offline about checking for the value of each
state and calling the corresponding enum for recordValue. However, this does not
fix the problem of keeping the 2 lists, the one here and the other in
histograms.xml in sync. So going with what seems to be a cleaner implementation.

+    buckets: 7

[anandc, 2015/08/21 16:23:01]

We only want to log when the connection state is after Initializing. So min is
2. The max expected value is 6, and histograms should be defined with the max to
be 1 above the expected value. And # of buckets should 1 above the total
distinct values to account for overflow.
I'll add these comments to the code later. Just sending this out for review now.
LMK if any of these are incorrect.

+  };
+
+  chrome.metricsPrivate.recordValue(metricDescription, state);
+}
+
+/**
  * @param {remoting.ClientSession.State} oldState The new state for the session.
  * @param {remoting.ClientSession.State} newState The new state for the session.
  * @private
  */
 remoting.ClientSession.prototype.notifyStateChanges_ =
     function(oldState, newState) {
   /** @type {remoting.Error} */
   var error;
   switch (this.state_) {
     case remoting.ClientSession.State.CONNECTED:
@@ skipping 76 matching lines @@
  * Enable or disable logging of connection errors due to a host being offline.
  * For example, if attempting a connection using a cached JID, host-offline
  * errors should not be logged because the JID will be refreshed and the
  * connection retried.
  *
  * @param {boolean} enable True to log host-offline errors; false to suppress.
  */
 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
   this.logHostOfflineErrors_ = enable;
 };