Add UMA stats for Chromoting connection details.

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #include <nacl_io/nacl_io.h>
@@ skipping 49 matching lines @@
 
 // Default DPI to assume for old clients that use notifyClientResolution.
 const int kDefaultDPI = 96;
 
 // Size of the random seed blob used to initialize RNG in libjingle. OpenSSL
 // needs at least 32 bytes of entropy (see
 // http://wiki.openssl.org/index.php/Random_Numbers), but stores 1039 bytes of
 // state, so we initialize it with 1k or random data.
 const int kRandomSeedSize = 1024;
 
+// The connection times and duration values are stored in UMA custom-time
+// histograms, specified based off values seen over a recent 7-day period.
+// The connection times histograms are in milliseconds and the connection
+// duration histograms are in minutes.
+const char kTimeToAuthenticateHistogram[] =
+    "Chromoting.Connections.Times.ToAuthenticate";
+const char kTimeToConnectHistogram[] = "Chromoting.Connections.Times.ToConnect";
+const char kClosedSessionDurationHistogram[] =
+    "Chromoting.Connections.Durations.Closed";
+const char kFailedSessionDurationHistogram[] =
+    "Chromoting.Connections.Durations.Failed";
+const int kConnectionTimesHistogramMinMs = 1;
+const int kConnectionTimesHistogramMaxMs = 30000;
+const int kConnectionTimesHistogramBuckets = 50;
+const int kConnectionDurationHistogramMinMinutes = 1;
+const int kConnectionDurationHistogramMaxMinutes = 24 * 60;
+const int kConnectionDurationHistogramBuckets = 50;

[Sergey Ulanov, 2015/08/21 18:26:48]

Not sure if 50 histograms is enough. Are these distributed linearly? I would
guess most sessions are shorter than 1 hour, but with 50 buckets over 24 hours
we will have only about 2 for the first hour

[anandc, 2015/08/21 18:56:56]

These are log-scaled. Added a note about that in the comments.

+
 // TODO(sergeyu): Ideally we should just pass ErrorCode to the webapp
 // and let it handle it, but it would be hard to fix it now because
 // client plugin and webapp versions may not be in sync. It should be
 // easy to do after we are finished moving the client plugin to NaCl.
 std::string ConnectionErrorToString(protocol::ErrorCode error) {
   // Values returned by this function must match the
   // remoting.ClientSession.Error enum in JS code.
   switch (error) {
     case protocol::OK:
       return "NONE";
@@ skipping 277 matching lines @@
   }
 
   scoped_ptr<base::DictionaryValue> data(new base::DictionaryValue());
   data->Set("rects", rects_value.release());
   PostLegacyJsonMessage("onDebugRegion", data.Pass());
 }
 
 void ChromotingInstance::OnConnectionState(
     protocol::ConnectionToHost::State state,
     protocol::ErrorCode error) {
+  pp::UMAPrivate uma(this);
+
+  switch (state) {
+    case protocol::ConnectionToHost::CONNECTING:
+      connection_started_time = base::TimeTicks::Now();
+      break;
+    case protocol::ConnectionToHost::AUTHENTICATED:
+      connection_authenticated_time_ = base::TimeTicks::Now();
+      uma.HistogramCustomTimes(
+          kTimeToAuthenticateHistogram,
+          (connection_authenticated_time_ - connection_started_time)
+              .InMilliseconds(),
+          kConnectionTimesHistogramMinMs, kConnectionTimesHistogramMaxMs,
+          kConnectionTimesHistogramBuckets);
+      break;
+    case protocol::ConnectionToHost::CONNECTED:
+      connection_connected_time_ = base::TimeTicks::Now();
+      uma.HistogramCustomTimes(
+          kTimeToConnectHistogram,
+          (connection_connected_time_ - connection_authenticated_time_)
+              .InMilliseconds(),
+          kConnectionTimesHistogramMinMs, kConnectionTimesHistogramMaxMs,
+          kConnectionTimesHistogramBuckets);
+      break;
+    case protocol::ConnectionToHost::CLOSED:
+      if (!connection_connected_time_.is_null()) {
+        uma.HistogramCustomTimes(
+            kClosedSessionDurationHistogram,
+            (base::TimeTicks::Now() - connection_connected_time_)
+                .InMilliseconds(),
+            kConnectionDurationHistogramMinMinutes,
+            kConnectionDurationHistogramMaxMinutes,
+            kConnectionDurationHistogramBuckets);
+      }
+      break;
+    case protocol::ConnectionToHost::FAILED:
+      if (!connection_connected_time_.is_null()) {
+        uma.HistogramCustomTimes(
+            kFailedSessionDurationHistogram,
+            (base::TimeTicks::Now() - connection_connected_time_)
+                .InMilliseconds(),
+            kConnectionDurationHistogramMinMinutes,
+            kConnectionDurationHistogramMaxMinutes,
+            kConnectionDurationHistogramBuckets);
+      }
+      break;
+    case protocol::ConnectionToHost::INITIALIZING:
+      break;

[Sergey Ulanov, 2015/08/21 18:26:48]

nit: Add NOTREACHED() here and move to the beginning of the list.

[anandc, 2015/08/21 18:56:56]

Done.

+  }
+
   scoped_ptr<base::DictionaryValue> data(new base::DictionaryValue());
   data->SetString("state", protocol::ConnectionToHost::StateToString(state));
   data->SetString("error", ConnectionErrorToString(error));
   PostLegacyJsonMessage("onConnectionStatus", data.Pass());
 }
 
 void ChromotingInstance::FetchThirdPartyToken(
     const GURL& token_url,
     const std::string& host_public_key,
     const std::string& scope,
@@ skipping 697 matching lines @@
 
   if (is_custom_counts_histogram)
     uma.HistogramCustomCounts(histogram_name, value, histogram_min,
                               histogram_max, histogram_buckets);
   else
     uma.HistogramCustomTimes(histogram_name, value, histogram_min,
                              histogram_max, histogram_buckets);
 }
 
 }  // namespace remoting