Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: pkg/analyzer/test/generated/static_warning_code_test.dart

Issue 1305433005: No more warnings for duplicate unnamed lib imports. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/static_warning_code_test.dart
diff --git a/pkg/analyzer/test/generated/static_warning_code_test.dart b/pkg/analyzer/test/generated/static_warning_code_test.dart
index a5b0555a77ec42eb42ee3778c8a7a59f2110fd4f..dfa76335c4cd7412dc46e16fd6103c164b8d4cf7 100644
--- a/pkg/analyzer/test/generated/static_warning_code_test.dart
+++ b/pkg/analyzer/test/generated/static_warning_code_test.dart
@@ -1272,7 +1272,9 @@ export 'lib2.dart';''');
addNamedSource("/lib1.dart", "");
addNamedSource("/lib2.dart", "");
computeLibrarySourceErrors(source);
- assertErrors(source, [StaticWarningCode.EXPORT_DUPLICATED_LIBRARY_UNNAMED]);
+ assertErrors(source, [
Paul Berry 2015/08/20 20:57:37 Use assertNoErrors() and move this test into the N
pquitslund 2015/08/20 21:23:43 Good call. Done!
+ // No warning (https://github.com/dart-lang/sdk/issues/24156)
+ ]);
verify([source]);
}
@@ -1497,7 +1499,7 @@ import 'lib2.dart';''');
addNamedSource("/lib2.dart", "");
computeLibrarySourceErrors(source);
assertErrors(source, [
- StaticWarningCode.IMPORT_DUPLICATED_LIBRARY_UNNAMED,
+ // No warning (https://github.com/dart-lang/sdk/issues/24156)
Paul Berry 2015/08/20 20:57:37 I think this test should be moved into NonErrorRes
pquitslund 2015/08/20 21:23:43 Works for me. Done.
HintCode.UNUSED_IMPORT,
HintCode.UNUSED_IMPORT
]);
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698