Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 130543002: Added "os" attribute in the component updater update requests. (Closed)

Created:
6 years, 11 months ago by Sorin Jianu
Modified:
6 years, 11 months ago
Reviewers:
waffles
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Added "os" attribute in the component updater update requests. In order to be compatible with the v2 version of the update protocol and existing update configuration files, the "os" attribute (and fwiw, "arch") must be serialized as part of the <request> element. BUG=332551 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/component_updater/component_updater_utils.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sorin Jianu
6 years, 11 months ago (2014-01-09 02:21:10 UTC) #1
waffles
lgtm
6 years, 11 months ago (2014-01-09 05:59:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/130543002/1
6 years, 11 months ago (2014-01-09 06:49:28 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 08:02:12 UTC) #4
Message was sent while issue was closed.
Change committed as 243809

Powered by Google App Engine
This is Rietveld 408576698