Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: lib/src/compiler.dart

Issue 1305413006: fix readability regressions from previous block-scope CL (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/compiler.dart
diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
index f5a0aecf82f7936cfba2fab49069c0eab25b1b64..1723d4c5fb58fb83a8a694452cf0c64c0b5c666c 100644
--- a/lib/src/compiler.dart
+++ b/lib/src/compiler.dart
@@ -173,20 +173,6 @@ class BatchCompiler extends AbstractCompiler {
}
if (_jsGen != null) {
- // TODO(jmesserly): full incremental support would avoid checking as well,
- // however, we'd lose compiler messages in that case.
-
- // Note: analyzer's modification stamp is millisecondsSinceEpoch
- int lastModifyTime = unitElements
- .map((e) => context.getModificationStamp(e.source))
- .reduce(math.max);
- var outFile = new File(getOutputPath(library.source.uri));
- if (outFile.existsSync() &&
- outFile.lastModifiedSync().millisecondsSinceEpoch >= lastModifyTime) {
- // Output already up to date.
- return;
- }
-
var unit = units.first;
var parts = units.skip(1).toList();
_jsGen.generateLibrary(new LibraryUnit(unit, parts));

Powered by Google App Engine
This is Rietveld 408576698