Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305383008: [GN] move gn doc to proper place (Closed)

Created:
5 years, 3 months ago by Bons
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] move gn doc to proper place R=dpranke@chromium.org BUG=none Committed: https://crrev.com/fe59edcf12d785724ab7bf12e7864452724e0c59 Cr-Commit-Position: refs/heads/master@{#346519}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -111 lines) Patch
D docs/gn_check.md View 1 chunk +0 lines, -112 lines 0 comments Download
M tools/gn/README.md View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tools/gn/docs/check.md View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Bons
5 years, 3 months ago (2015-08-31 22:43:31 UTC) #1
Dirk Pranke
Can you add a link to this from //tools/gn/README.md ? Otherwise I don't think anything ...
5 years, 3 months ago (2015-08-31 22:57:41 UTC) #2
Bons
On 2015/08/31 22:57:41, Dirk Pranke wrote: > Can you add a link to this from ...
5 years, 3 months ago (2015-08-31 23:07:09 UTC) #3
Dirk Pranke
lgtm
5 years, 3 months ago (2015-08-31 23:13:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305383008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305383008/20001
5 years, 3 months ago (2015-08-31 23:13:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-31 23:36:07 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 23:36:58 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe59edcf12d785724ab7bf12e7864452724e0c59
Cr-Commit-Position: refs/heads/master@{#346519}

Powered by Google App Engine
This is Rietveld 408576698