Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp - Issue 1305383006: Oilpan: Unship CSSValues and AnimatableValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

Issue 1305383006: Oilpan: Unship CSSValues and AnimatableValues Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/SVGStrokeDasharrayStyleInterpolation.h ('k') | Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

diff --git a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

index ffb4822c9f0c4f9d61343d26f8463ef58039106b..54f3d335f5f9a005515fbc4868a8d45e50598e04 100644

--- a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

+++ b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

@@ -25,11 +25,11 @@ bool isNone(const CSSValue& value)

} // namespace

-PassRefPtrWillBeRawPtr<CSSValueList> SVGStrokeDasharrayStyleInterpolation::interpolableValueToStrokeDasharray(const InterpolableValue& interpolableValue)

+PassRefPtr<CSSValueList> SVGStrokeDasharrayStyleInterpolation::interpolableValueToStrokeDasharray(const InterpolableValue& interpolableValue)

{

const InterpolableList& interpolableList = toInterpolableList(interpolableValue);

- RefPtrWillBeRawPtr<CSSValueList> ret = CSSValueList::createCommaSeparated();

+ RefPtr<CSSValueList> ret = CSSValueList::createCommaSeparated();

for (size_t index = 0; index < interpolableList.length(); ++index)

ret->append(LengthStyleInterpolation::fromInterpolableValue(*interpolableList.get(index), RangeNonNegative));

return ret.release();

@@ -53,7 +53,7 @@ PassRefPtrWillBeRawPtr<SVGStrokeDasharrayStyleInterpolation> SVGStrokeDasharrayS

if (!canCreateFrom(start) || !canCreateFrom(end))

return nullptr;

- RefPtrWillBeRawPtr<CSSValueList> singleZero = CSSValueList::createCommaSeparated();

+ RefPtr<CSSValueList> singleZero = CSSValueList::createCommaSeparated();

singleZero->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::UnitType::Pixels));

const CSSValueList& valueListStart = start.isValueList() ? toCSSValueList(start) : *singleZero;

@@ -61,8 +61,8 @@ PassRefPtrWillBeRawPtr<SVGStrokeDasharrayStyleInterpolation> SVGStrokeDasharrayS

size_t size = lowestCommonMultiple(valueListStart.length(), valueListEnd.length());

ASSERT(size > 0);

- OwnPtrWillBeRawPtr<InterpolableList> interpolableStart = InterpolableList::create(size);

- OwnPtrWillBeRawPtr<InterpolableList> interpolableEnd = InterpolableList::create(size);

+ OwnPtr<InterpolableList> interpolableStart = InterpolableList::create(size);

+ OwnPtr<InterpolableList> interpolableEnd = InterpolableList::create(size);

for (size_t i = 0; i < size; ++i) {

const CSSPrimitiveValue& from = *toCSSPrimitiveValue(valueListStart.item(i % valueListStart.length()));