Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305373004: DevTools: move session logic from TracingModel to TimelineModel (Closed)

Created:
5 years, 3 months ago by caseq
Modified:
5 years, 3 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: move session logic from TracingModel to TimelineModel This should remove stray "TracingStartedInPage event not found" message when using screenshot recorder in Network panel. - extract processMetadataEvents() from TracingModel to TimelineModel - ditto for session id - nuked TracingModel.Loader BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201649

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -165 lines) Patch
M LayoutTests/inspector/tracing-model-async-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing-model-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing-model-storage-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing-session-id.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/worker-events.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/TracingModel.js View 1 9 chunks +5 lines, -137 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 13 chunks +111 lines, -18 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
caseq
5 years, 3 months ago (2015-09-01 00:48:46 UTC) #2
alph
lgtm https://codereview.chromium.org/1305373004/diff/1/Source/devtools/front_end/sdk/TracingModel.js File Source/devtools/front_end/sdk/TracingModel.js (right): https://codereview.chromium.org/1305373004/diff/1/Source/devtools/front_end/sdk/TracingModel.js#newcode205 Source/devtools/front_end/sdk/TracingModel.js:205: revert plz https://codereview.chromium.org/1305373004/diff/1/Source/devtools/front_end/timeline/TimelineModel.js File Source/devtools/front_end/timeline/TimelineModel.js (right): https://codereview.chromium.org/1305373004/diff/1/Source/devtools/front_end/timeline/TimelineModel.js#newcode305 Source/devtools/front_end/timeline/TimelineModel.js:305: ...
5 years, 3 months ago (2015-09-01 21:11:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305373004/20001
5 years, 3 months ago (2015-09-02 01:27:34 UTC) #5
caseq
On 2015/09/01 21:11:42, alph wrote: > lgtm > > https://codereview.chromium.org/1305373004/diff/1/Source/devtools/front_end/sdk/TracingModel.js > File Source/devtools/front_end/sdk/TracingModel.js (right): > ...
5 years, 3 months ago (2015-09-02 01:28:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 02:39:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305373004/20001
5 years, 3 months ago (2015-09-02 16:03:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 16:08:12 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201649

Powered by Google App Engine
This is Rietveld 408576698