Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 1305373002: DevTools: [timeline tree view] (unattributed) costs include extension overhead in Domain grouping (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/Source/devtools/front_end/timeline/TimelineTreeView.js b/Source/devtools/front_end/timeline/TimelineTreeView.js
index 0bf6de842e1dd08fe1c0206a41248d53cff99abc..62719ff88942934f31239d1134cc04748c59a033 100644
--- a/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -188,11 +188,14 @@ WebInspector.TimelineTreeView.prototype = {
*/
function groupByDomain(groupSubdomains, node)
{
- var parsedURL = (WebInspector.TimelineTreeView.eventURL(node.event) || "").asParsedURL();
+ var url = WebInspector.TimelineTreeView.eventURL(node.event) || "";
+ if (url.startsWith("extensions::"))
+ return groupSubdomains ? WebInspector.UIString("Chrome Extensions Overhead") : url;
+ var parsedURL = url.asParsedURL();
if (!parsedURL)
return "";
if (parsedURL.scheme === "chrome-extension") {
- var url = parsedURL.scheme + "://" + parsedURL.host;
+ url = parsedURL.scheme + "://" + parsedURL.host;
var displayName = executionContextNamesByOrigin.get(url);
return displayName ? WebInspector.UIString("Chrome Extension: %s", displayName) : url;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698