Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 1305353013: Tests for user gesture detection in page click tracker. [DO NOT REVIEW] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@user-gesture
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.h
diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h
index eed10f9a810b2be3eff48b9819cba14882ce0057..769251cdaa3c3b78cf675bee66e99c937f8fb41f 100644
--- a/components/autofill/content/renderer/page_click_tracker.h
+++ b/components/autofill/content/renderer/page_click_tracker.h
@@ -8,6 +8,7 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
#include "base/memory/weak_ptr.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_view_observer.h"
@@ -50,9 +51,26 @@ class PageClickTracker : public content::RenderFrameObserver {
};
friend class Legacy;
+ FRIEND_TEST_ALL_PREFIXES(
+ PageClickTrackerTest, KeyboardAccessoryForMouseDown);
+ FRIEND_TEST_ALL_PREFIXES(
+ PageClickTrackerTest, KeyboardAccessoryForUserGestureFocusedNodeChange);
+ FRIEND_TEST_ALL_PREFIXES(
+ PageClickTrackerTest,
+ NoKeyboardAccessoryForNonUserGestureFocusedNodeChange);
+ FRIEND_TEST_ALL_PREFIXES(
+ PageClickTrackerTest, NoKeyboardAccessoryForFocusChangeComplete);
+
// RenderFrameObserver implementation.
void FocusedNodeChanged(const blink::WebNode& node) override;
+ // Returns true if the focused node change is due to a user gesture. Can be
+ // overridden in tests.
+ virtual bool IsUserGesture() const;
+
+ // Returns true if keyboard accessory is enabled. Can be overridden in tests.
+ virtual bool IsKeyboardAccessory() const;
+
// RenderViewObserver methods forwarded from Legacy. Should be
// merged into RenderFrameObserver.
void OnMouseDown(const blink::WebNode& mouse_down_node);
« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | components/autofill/content/renderer/page_click_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698