Issue 1305353011: Use WTF ASSERT in AXNodeObject.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1305353011: Use WTF ASSERT in AXNodeObject.cpp. (Closed)

Created:
5 years, 3 months ago by jbroman

Modified:
5 years, 3 months ago

Reviewers:
dmazzoni

CC:
aboxhall, blink-reviews, dmazzoni, je_julie, nektarios, blundell

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use WTF ASSERT in AXNodeObject.cpp. The lowercase version comes from <cassert>, and shouldn't be used within Blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201923

Patch Set 1 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/modules/accessibility/AXNodeObject.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jbroman

Noticed by blundell@: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/IIkOmt66zEc/W5CuUVJgKgAJ

5 years, 3 months ago (2015-09-08 16:29:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305353011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305353011/20001

5 years, 3 months ago (2015-09-08 16:38:45 UTC) #6

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 18:02:06 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201923

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages