Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1305353010: Remove LeftTrimFixedArray (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] [ElementsAccessor] Remove LeftTrimFixedArray Left trimming has been disabled in the GC since a while and elements.cc is one of the few places left relying on this. Since CanMoveObjectStart returns false by default now I am stripping away all the code relying on it. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -75 lines) Patch
M src/elements.cc View 2 chunks +5 lines, -22 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305353010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305353010/1
5 years, 3 months ago (2015-09-08 13:16:18 UTC) #2
Camillo Bruni
PTAL
5 years, 3 months ago (2015-09-08 13:17:01 UTC) #4
ulan
Is it blocking other work or is it purely cleanup? In the latter case, I ...
5 years, 3 months ago (2015-09-08 13:22:13 UTC) #5
Camillo Bruni
On 2015/09/08 at 13:22:13, ulan wrote: > Is it blocking other work or is it ...
5 years, 3 months ago (2015-09-08 13:30:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 13:42:08 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305353010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305353010/1
5 years ago (2015-12-04 08:52:17 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-04 08:53:18 UTC) #12
Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11012)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11621)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8535)

Powered by Google App Engine
This is Rietveld 408576698