Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1305333002: Clearly label incognito profiles in the appcache-internals webui. (Closed)

Created:
5 years, 4 months ago by michaeln
Modified:
5 years, 4 months ago
Reviewers:
EhsanK
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clearly label incognito profiles in the appcache-internals webui. TBR=jsbell Committed: https://crrev.com/eb11a0fb861c56036004625a33ae1b17c98a6921 Cr-Commit-Position: refs/heads/master@{#345459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/appcache/appcache_internals_ui.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
michaeln
ptal
5 years, 4 months ago (2015-08-21 22:06:33 UTC) #2
EhsanK
I am sorry it took me a while. Thanks for the change. lgtm.
5 years, 4 months ago (2015-08-25 14:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305333002/1
5 years, 4 months ago (2015-08-25 21:07:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-25 21:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305333002/1
5 years, 4 months ago (2015-08-25 21:09:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 22:30:11 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 22:31:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb11a0fb861c56036004625a33ae1b17c98a6921
Cr-Commit-Position: refs/heads/master@{#345459}

Powered by Google App Engine
This is Rietveld 408576698