Issue 130533003: Remove fullPaths from the file_grid.js and file_table.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130533003: Remove fullPaths from the file_grid.js and file_table.js. (Closed)

Created:
6 years, 11 months ago by mtomasz

Modified:
6 years, 11 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove fullPaths from the file_grid.js and file_table.js. This patch removes fullPaths from the file views, by using the volume manager and the getLocationInfo() method instead. BUG=320967 TEST=Tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243881

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -19 lines)			Patch
M	chrome/browser/resources/file_manager/foreground/js/file_grid.js	View	8 chunks	+17 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_manager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_table.js	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/ui/preview_panel.js	View	4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/130533003/1

6 years, 11 months ago (2014-01-09 04:17:55 UTC) #3

Message was sent while issue was closed.

Change committed as 243881

Expand Messages | Collapse Messages