Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1305313008: [turbofan] Factored out the test live range builder. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Factored out the test live range builder. I plan to reuse this for live range splitting/splintering/merging tests. BUG= Committed: https://crrev.com/9987734fe5fcbd668627071e517b2c8a34e85778 Cr-Commit-Position: refs/heads/master@{#30461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -44 lines) Patch
M test/unittests/compiler/coalesced-live-ranges-unittest.cc View 2 chunks +1 line, -44 lines 0 comments Download
A test/unittests/compiler/live-range-builder.h View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-31 09:30:55 UTC) #2
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-08-31 09:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305313008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305313008/1
5 years, 3 months ago (2015-08-31 09:53:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 09:57:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 09:57:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9987734fe5fcbd668627071e517b2c8a34e85778
Cr-Commit-Position: refs/heads/master@{#30461}

Powered by Google App Engine
This is Rietveld 408576698