net/quic/quic_stream_factory_test.cc - Issue 1305293004: Notfiy NQE of QUIC RTT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 1305293004: Notfiy NQE of QUIC RTT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed rch comments, now using quic connection logger Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_stream_factory_test.cc

diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc

index 43a22967b05314b949fe7afb1b02092c0e3d653d..2ebc20866a59cbaad079cba3850f1964211ace50 100644

--- a/net/quic/quic_stream_factory_test.cc

+++ b/net/quic/quic_stream_factory_test.cc

@@ -229,6 +229,7 @@ class QuicStreamFactoryTest : public ::testing::TestWithParam<TestParams> {

nullptr,

channel_id_service_.get(),

&transport_security_state_,

+ /*SocketPerformanceWatcherFactory*/ nullptr,

&crypto_client_stream_factory_,

&random_generator_,

clock_,