net/quic/test_tools/quic_test_utils.cc - Issue 1305293004: Notfiy NQE of QUIC RTT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 1305293004: Notfiy NQE of QUIC RTT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated with more comments and tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/test_tools/quic_test_utils.cc

diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc

index cab2bf72098cafece9b708034a1e5e9729747cbd..0034cf453b1fbb100efc7b66be78a797a18febba 100644

--- a/net/quic/test_tools/quic_test_utils.cc

+++ b/net/quic/test_tools/quic_test_utils.cc

@@ -30,6 +30,9 @@ using testing::Invoke;

using testing::_;

namespace net {

+class SocketPerformanceWatcher;

namespace test {

namespace {

@@ -294,7 +297,8 @@ MockConnection::MockConnection(QuicConnectionId connection_id,

/* owns_writer= */ true,

perspective,

is_secure,

- supported_versions),

+ supported_versions,

+ scoped_ptr<SocketPerformanceWatcher>()),

helper_(helper()) {

ON_CALL(*this, OnError(_))

.WillByDefault(