Notfiy NQE of QUIC RTT

net/quic/quic_connection_logger.h

Index: net/quic/quic_connection_logger.h
diff --git a/net/quic/quic_connection_logger.h b/net/quic/quic_connection_logger.h
index 1d0e62f93ea5af70e1836c59a20081293ecd541e..a388a34742ad67c0b497a6adfb4614c0d3e485b7 100644
--- a/net/quic/quic_connection_logger.h
+++ b/net/quic/quic_connection_logger.h
@@ -9,6 +9,7 @@
 
 #include "net/base/ip_endpoint.h"
 #include "net/base/network_change_notifier.h"
+#include "net/base/socket_performance_watcher.h"
 #include "net/log/net_log.h"
 #include "net/quic/quic_connection.h"
 #include "net/quic/quic_protocol.h"
@@ -27,9 +28,11 @@ class CertVerifyResult;
 class NET_EXPORT_PRIVATE QuicConnectionLogger
     : public QuicConnectionDebugVisitor {
  public:
-  QuicConnectionLogger(QuicSpdySession* session,
-                       const char* const connection_description,
-                       const BoundNetLog& net_log);
+  QuicConnectionLogger(
+      QuicSpdySession* session,
+      const char* const connection_description,
+      scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+      const BoundNetLog& net_log);
 
   ~QuicConnectionLogger() override;
 
@@ -68,6 +71,7 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
                        base::StringPiece payload) override;
   void OnConnectionClosed(QuicErrorCode error, bool from_peer) override;
   void OnSuccessfulVersionNegotiation(const QuicVersion& version) override;
+  void OnRttChanged(QuicTime::Delta rtt) const override;
 
   void OnCryptoHandshakeMessageReceived(
       const CryptoHandshakeMessage& message);
@@ -177,6 +181,9 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
   // The available type of connection (WiFi, 3G, etc.) when connection was first
   // used.
   const char* const connection_description_;
+  // Watches the performance of the UDP socket underlying this QUIC connection.

[Ryan Sleevi, 2015/09/18 17:36:45]

Wording nit:
// Receives notifications regarding the performance of the underlying socket for
the QUIC connection.

It doesn't watch (implies proactive observation), since it's in fact notified by
this class. Also, slightly rewords the latter part to avoid the explicit mention
of both UDP and this (these are more pet peeves :P - the former being
over-specifying the implementation, the latter being avoiding self-references
when possible)

[tbansal1, 2015/09/18 17:59:59]

Done. That makes sense, I need to be more careful when naming things. Hope I can
get better :)

+  // May be null.
+  const scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicConnectionLogger);
 };