Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305293003: Allow to set a fixed port for the development server. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
Reviewers:
tonyg
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow to set a fixed port for the development server. Running on the fixed port enables service cache to store responses between shell runs. Fixes domokit/devtools#37 R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b5a95ab8ee61e1ed8295df23a21b9672a8057c91

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address Tony's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/devtools/common/remote_adb_setup View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojoconfig View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Tony, ptal.
5 years, 3 months ago (2015-08-25 13:07:57 UTC) #2
tonyg
lgtm https://codereview.chromium.org/1305293003/diff/20001/mojoconfig File mojoconfig (right): https://codereview.chromium.org/1305293003/diff/20001/mojoconfig#newcode19 mojoconfig:19: 'port': 31839, We may as well make this ...
5 years, 3 months ago (2015-08-25 13:29:15 UTC) #3
ppi
https://codereview.chromium.org/1305293003/diff/20001/mojoconfig File mojoconfig (right): https://codereview.chromium.org/1305293003/diff/20001/mojoconfig#newcode19 mojoconfig:19: 'port': 31839, On 2015/08/25 13:29:15, tonyg wrote: > We ...
5 years, 3 months ago (2015-08-25 14:59:59 UTC) #4
ppi
5 years, 3 months ago (2015-08-25 15:00:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b5a95ab8ee61e1ed8295df23a21b9672a8057c91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698