Don't short-circuit MSE seeks in WebMediaPlayer impls

Don't short-circuit MSE seeks in WebMediaPlayer impls

Underlying buffers might have been removed or replaced by different
buffers since they were fed to preroll decoders, so we must not always
make MSE seeks to the same time as an in-progress seek (WMPI and WMPA)
or the current pause time (WMPI) no-ops. Later refactoring might
re-introduce short-circuiting (with asynch completion signalling),
but conditionally if nothing in SourceBufferStream has changed since
the last seek. This change is kept small to fix the functional
issue while increasing merge-ability.

BUG=526337, 399523, 303419, 284782, 266631
R=chcunningham@chromium.org,sandersd@chromium.org,qinmin@chromium.org

Committed: https://crrev.com/a609797f7b3e68f1214b983b846a1d457385098a
Cr-Commit-Position: refs/heads/master@{#346575}

[wolenetz, 2015-08-31 21:01:20]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 21:01:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305273007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305273007/1

[wolenetz, 2015-08-31 21:02:00]

Per our chat offline, please take a look at patch set 1:
sandersd@: committer, everything
chcunningham@: everything (from MSE perspective)

Thanks!

[wolenetz, 2015-08-31 21:15:31]

Per chat w/sandersd@ just now:

https://codereview.chromium.org/1305273007/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1305273007/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:306: if (!pending_seek_) {
This is another instance of short-circuiting redundant seeks for MSE, but in the
case where a seek is still outstanding (from the P.O.V. of the renderer main
thread). I'll take a further look, though, since maybe an "onPipelineSeeked" is
on it's way from the media thread when we get to this logic, and maybe the media
thread (and renderers) have already started to consume old buffers. It seems to
me to be less fragile to remove this short-circuiting, so I'll probably have
another patch set coming that does this (for MSE).

[commit-bot: I haz the power, 2015-08-31 21:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 21:53:43]

Dry run: This issue passed the CQ dry run.

[wolenetz, 2015-08-31 22:14:47]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 22:15:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305273007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305273007/20001

[wolenetz, 2015-08-31 22:19:11]

Please take a look at patch set 2:
qinmin@: c/r/m/android/* OWNER and committer
sandersd@: m/blink/* committer
chcunningham@: everything (MSE p.o.v.)

Thanks!

https://codereview.chromium.org/1305273007/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1305273007/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:306: if (!pending_seek_) {
On 2015/08/31 21:15:31, wolenetz wrote:
> This is another instance of short-circuiting redundant seeks for MSE, but in
the
> case where a seek is still outstanding (from the P.O.V. of the renderer main
> thread). I'll take a further look, though, since maybe an "onPipelineSeeked"
is
> on it's way from the media thread when we get to this logic, and maybe the
media
> thread (and renderers) have already started to consume old buffers. It seems
to
> me to be less fragile to remove this short-circuiting, so I'll probably have
> another patch set coming that does this (for MSE).

Patch set 2 removes this kind of short-circuiting from both WMPI and WMPA.

[sandersd (OOO until July 31), 2015-08-31 22:27:46]

lgtm

[commit-bot: I haz the power, 2015-08-31 22:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 22:34:30]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[wolenetz, 2015-08-31 22:44:30]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 22:44:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305273007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305273007/40001

[wolenetz, 2015-08-31 22:45:30]

Thanks Dan.
qinmin@, chcunningham@: Patch set 3 contains a (hopeful) fix for compile on
Android builds. Please take a look.

[commit-bot: I haz the power, 2015-08-31 23:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:02:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[qinmin, 2015-08-31 23:08:01]

qinmin@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2015-08-31 23:08:01]

lgtm

[wolenetz, 2015-08-31 23:08:05]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 23:08:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305273007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305273007/60001

[wolenetz, 2015-08-31 23:10:49]

Thanks Min.
chcunningham@, please take a look at patch set 4 (which contains yet another
attempt to fix compile on chrome for android)

[commit-bot: I haz the power, 2015-08-31 23:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:40:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chcunningham, 2015-08-31 23:45:20]

lgtm

[wolenetz, 2015-08-31 23:47:59]

Thanks for reviews. I'll land this via CQ once the Blink-side change to
mediasource-duration layout expectation lands and rolls into Chromium.

[wolenetz, 2015-08-31 23:48:18]

On 2015/08/31 23:47:59, wolenetz wrote:
> Thanks for reviews. I'll land this via CQ once the Blink-side change to
> mediasource-duration layout expectation lands and rolls into Chromium.

(Blink-side change is https://codereview.chromium.org/1321253005/)

[wolenetz, 2015-09-01 05:01:43]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2015-09-01 05:01:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1305273007/#ps60001
(title: "Fix a further build issue for Android")

[commit-bot: I haz the power, 2015-09-01 05:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305273007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305273007/60001

[commit-bot: I haz the power, 2015-09-01 05:38:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-01 05:38:46]

Patchset 4 (id:??) landed as
https://crrev.com/a609797f7b3e68f1214b983b846a1d457385098a
Cr-Commit-Position: refs/heads/master@{#346575}