chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java - Issue 1305253006: [Custom Tabs]Add API for updating action button as ContentProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 1305253006: [Custom Tabs]Add API for updating action button as ContentProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabUpdater.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

index a858e2896048b2e4144e2c9bd85cc57bfdf5bf87..6f5ec3ca5e5cf170a2b83f8b43bc36463244644e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

@@ -383,12 +383,12 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {

public void setCloseButtonImageResource(Drawable drawable) { }

/**

- * Adds a custom action button to the {@link ToolbarLayout} if it is supported.

+ * Sets/adds a custom action button to the {@link ToolbarLayout} if it is supported.

* @param description The content description for the button.

* @param listener The {@link OnClickListener} to use for clicks to the button.

* @param buttonSource The {@link Bitmap} resource to use as the source for the button.

- public void addCustomActionButton(Drawable drawable, String description,

+ public void setCustomActionButton(Drawable drawable, String description,

OnClickListener listener) { }

/**