Issue 1305223010: Merge to XFA: Cleanup dead code in CPDF_DIBSource::LoadJpxBitmap() and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1305223010: Merge to XFA: Cleanup dead code in CPDF_DIBSource::LoadJpxBitmap() and friends. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Cleanup dead code in CPDF_DIBSource::LoadJpxBitmap() and friends. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1310603006 . (cherry picked from commit 097297325e0d3d00556d67885547750a2e9d4b32) Committed: https://pdfium.googlesource.com/pdfium/+/662816e763bbefe21c8c1b154328e131321f56b6

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -101 lines)			Patch
M	core/include/fxcodec/fx_codec.h	View	3 chunks	+12 lines, -11 lines	1 comment	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	3 chunks	+25 lines, -35 lines	0 comments	Download
M	core/src/fxcodec/codec/codec_int.h	View	1 chunk	+13 lines, -12 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpx_opj.cpp	View	4 chunks	+42 lines, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR, 99% conflict free merge. https://codereview.chromium.org/1305223010/diff/1/core/include/fxcodec/fx_codec.h File core/include/fxcodec/fx_codec.h (right): https://codereview.chromium.org/1305223010/diff/1/core/include/fxcodec/fx_codec.h#newcode353 core/include/fxcodec/fx_codec.h:353: There was a conflict ...

5 years, 3 months ago (2015-09-03 21:38:40 UTC) #1

Lei Zhang

5 years, 3 months ago (2015-09-03 21:38:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
662816e763bbefe21c8c1b154328e131321f56b6 (presubmit successful).

Expand Messages | Collapse Messages