Correct handling of |for| and |event| attributes of script elements.

Correct handling of |for| and |event| attributes of script elements.

https://html.spec.whatwg.org/multipage/scripting.html#script-processing-for
> 12. If the script element has an event attribute and a for attribute, then run
> these substeps:

Our implementation was "... has a non-empty event attribute and a non-empty for
attribute, ...".  This CL corrects isEmpty() checks to isNull().
The new behavior is compatible with IE and Firefox.

BUG=520844
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201627

[tkent, 2015-09-02 07:37:30]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2015-09-02 07:37:31]

kochi@, would you review this please?

https://codereview.chromium.org/1305213005/diff/1/Source/core/dom/ScriptLoade...
File Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/1305213005/diff/1/Source/core/dom/ScriptLoade...
Source/core/dom/ScriptLoader.cpp:485: if (eventAttribute.isNull() ||
forAttribute.isNull())
This change might look complex, but it's
 - Replacing isEmpty() with isNull()
 - Applying early return.

[kochi, 2015-09-02 07:47:07]

lgtm

https://codereview.chromium.org/1305213005/diff/1/Source/core/dom/ScriptLoade...
File Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/1305213005/diff/1/Source/core/dom/ScriptLoade...
Source/core/dom/ScriptLoader.cpp:485: if (eventAttribute.isNull() ||
forAttribute.isNull())
On 2015/09/02 07:37:31, tkent wrote:
> This change might look complex, but it's
>  - Replacing isEmpty() with isNull()
>  - Applying early return.

Acknowledged.

[tkent, 2015-09-02 07:47:51]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-02 07:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305213005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305213005/1

[commit-bot: I haz the power, 2015-09-02 08:03:14]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201627