Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1305213003: Convert ChromeSyncShell to use ChromePublic infrastructure (try #2) (Closed)

Created:
5 years, 4 months ago by pval...(no longer on Chromium)
Modified:
5 years, 3 months ago
Reviewers:
jbudorick, newt (away)
CC:
chromium-reviews, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ChromeSyncShell to use ChromePublic infrastructure (try #2) This is a re-land of the patch originally committed as part of https://codereview.chromium.org/1282603005/. The one major change is that a landmine has been added to clobber the Android arm64 bot as it caused problems after the original commit. Several test fixes are included to support this change. Note: This CL only provides a GYP implementation (no GN). This is not a regression from the previous state. BUG=510211 Committed: https://crrev.com/a715a2f88e842329e6133390788b6d8d22bf8201 Cr-Commit-Position: refs/heads/master@{#345392}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -485 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +0 lines, -69 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 8 chunks +170 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 2 chunks +2 lines, -0 lines 0 comments Download
D chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/android/sync_shell/java/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 2 chunks +18 lines, -16 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 4 chunks +12 lines, -22 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 7 chunks +32 lines, -33 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 4 chunks +18 lines, -12 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/android/chrome_sync_shell_main_delegate.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_sync_shell_main_delegate.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A + chrome/browser/android/chrome_sync_shell_main_delegate_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_shell.gypi View 2 chunks +0 lines, -65 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 4 chunks +4 lines, -0 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305213003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305213003/60001
5 years, 4 months ago (2015-08-25 01:41:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 03:01:48 UTC) #7
pval...(no longer on Chromium)
Here's the re-land CL. I've also uploaded the patchset from this issue to the original ...
5 years, 3 months ago (2015-08-25 17:51:36 UTC) #9
jbudorick
lgtm
5 years, 3 months ago (2015-08-25 18:11:28 UTC) #10
newt (away)
lgtm
5 years, 3 months ago (2015-08-25 18:32:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305213003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305213003/60001
5 years, 3 months ago (2015-08-25 18:36:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 3 months ago (2015-08-25 18:44:09 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 18:45:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a715a2f88e842329e6133390788b6d8d22bf8201
Cr-Commit-Position: refs/heads/master@{#345392}

Powered by Google App Engine
This is Rietveld 408576698