Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: apps/benchmark/args.h

Issue 1305193002: Trace-based benchmarking via a mojo app. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address James's comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/benchmark/args.h
diff --git a/apps/benchmark/args.h b/apps/benchmark/args.h
new file mode 100644
index 0000000000000000000000000000000000000000..2e9c20557db1225f4f403e342310c4faec646061
--- /dev/null
+++ b/apps/benchmark/args.h
@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef APPS_BENCHMARK_ARGS_H_
+#define APPS_BENCHMARK_ARGS_H_
+
+#include <string>
+#include <vector>
+
+#include "apps/benchmark/measurements.h"
+#include "base/time/time.h"
+
+namespace benchmark {
+
+// Represents arguments for a run of the benchmark app.
+struct Args {
etiennej 2015/08/28 13:54:37 I would call it BenchmarkRunParameters.
ppi 2015/08/28 14:02:06 We are already in the namespace benchmark. I can s
ppi 2015/08/28 14:17:12 Changed to RunArgs as discussed offline.
+ std::string app;
+ base::TimeDelta duration;
+ std::vector<Measurement> measurements;
+
+ Args();
etiennej 2015/08/28 13:54:37 I don't think you need a constructor or a destruct
ppi 2015/08/28 14:02:06 You need to explicitly declare it and define out-o
+ ~Args();
+};
+
+// Parses the arguments representation from the format provided by
+// ApplicationImpl::args(). Returns true iff the arguments were correctly parsed
+// and stored in |result|.
+bool GetArgs(const std::vector<std::string>& input_args, Args* result);
+
+} // namespace benchmark
+
+#endif // APPS_BENCHMARK_ARGS_H_
« no previous file with comments | « apps/benchmark/README.md ('k') | apps/benchmark/args.cc » ('j') | apps/benchmark/event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698