Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: apps/benchmark/run_args.cc

Issue 1305193002: Trace-based benchmarking via a mojo app. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Further address Etienne's comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/benchmark/run_args.h ('k') | apps/benchmark/trace_collector_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/benchmark/run_args.cc
diff --git a/apps/benchmark/run_args.cc b/apps/benchmark/run_args.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6767c3e97de8a42913cf3a9b692aaef6c4230ea6
--- /dev/null
+++ b/apps/benchmark/run_args.cc
@@ -0,0 +1,84 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "apps/benchmark/run_args.h"
+
+#include <algorithm>
+
+#include "base/command_line.h"
+#include "base/logging.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
+
+namespace benchmark {
+namespace {
+
+bool GetMeasurement(const std::string& measurement_spec, Measurement* result) {
+ // Measurements are described in the format:
+ // <measurement type>/<event category>/<event name>.
+ std::vector<std::string> parts;
+ base::SplitString(measurement_spec, '/', &parts);
+ if (parts.size() != 3) {
+ LOG(ERROR) << "Could not parse the measurement description: "
+ << measurement_spec;
+ return false;
+ }
+
+ if (parts[0] == "time_until") {
+ result->type = MeasurementType::TIME_UNTIL;
+ } else if (parts[0] == "avg_duration") {
+ result->type = MeasurementType::AVG_DURATION;
+ } else {
+ LOG(ERROR) << "Could not recognize the measurement type: " << parts[0];
+ return false;
+ }
+
+ result->target_event.category = parts[1];
+ result->target_event.name = parts[2];
+ result->spec = measurement_spec;
+ return true;
+}
+
+} // namespace
+
+RunArgs::RunArgs() {}
+
+RunArgs::~RunArgs() {}
+
+bool GetRunArgs(const std::vector<std::string>& input_args, RunArgs* result) {
+ base::CommandLine command_line(input_args);
+
+ result->app = command_line.GetSwitchValueASCII("app");
+ if (result->app.empty()) {
+ LOG(ERROR) << "The required --app argument is empty or missing.";
+ return false;
+ }
+
+ std::string duration_str = command_line.GetSwitchValueASCII("duration");
+ if (duration_str.empty()) {
+ LOG(ERROR) << "The required --duration argument is empty or missing.";
+ return false;
+ }
+ int duration_int;
+ if (!base::StringToInt(duration_str, &duration_int) || duration_int <= 0) {
+ LOG(ERROR) << "Could not parse the --duration value as a positive integer: "
+ << duration_str;
+ return false;
+ }
+ result->duration = base::TimeDelta::FromSeconds(duration_int);
+
+ // All regular arguments (not switches, ie. not preceded by "--") describe
+ // measurements.
+ for (const std::string& measurement_spec : command_line.GetArgs()) {
+ Measurement measurement;
+ if (!GetMeasurement(measurement_spec, &measurement)) {
+ return false;
+ }
+ result->measurements.push_back(measurement);
+ }
+
+ return true;
+}
+
+} // namespace benchmark
« no previous file with comments | « apps/benchmark/run_args.h ('k') | apps/benchmark/trace_collector_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698