Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: apps/benchmark/args.h

Issue 1305193002: Trace-based benchmarking via a mojo app. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address James's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef APPS_BENCHMARK_ARGS_H_
6 #define APPS_BENCHMARK_ARGS_H_
7
8 #include <string>
9 #include <vector>
10
11 #include "apps/benchmark/measurements.h"
12 #include "base/time/time.h"
13
14 namespace benchmark {
15
16 // Represents arguments for a run of the benchmark app.
17 struct Args {
etiennej 2015/08/28 13:54:37 I would call it BenchmarkRunParameters.
ppi 2015/08/28 14:02:06 We are already in the namespace benchmark. I can s
ppi 2015/08/28 14:17:12 Changed to RunArgs as discussed offline.
18 std::string app;
19 base::TimeDelta duration;
20 std::vector<Measurement> measurements;
21
22 Args();
etiennej 2015/08/28 13:54:37 I don't think you need a constructor or a destruct
ppi 2015/08/28 14:02:06 You need to explicitly declare it and define out-o
23 ~Args();
24 };
25
26 // Parses the arguments representation from the format provided by
27 // ApplicationImpl::args(). Returns true iff the arguments were correctly parsed
28 // and stored in |result|.
29 bool GetArgs(const std::vector<std::string>& input_args, Args* result);
30
31 } // namespace benchmark
32
33 #endif // APPS_BENCHMARK_ARGS_H_
OLDNEW
« no previous file with comments | « apps/benchmark/README.md ('k') | apps/benchmark/args.cc » ('j') | apps/benchmark/event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698