Issue 1305183010: - Reorder the priority of flags in the test harness when passed to the VM:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1305183010: - Reorder the priority of flags in the test harness when passed to the VM: (Closed)

Created:
5 years, 3 months ago by Ivan Posva

Modified:
5 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

- Reorder the priority of flags in the test harness when passed to the VM: default flags, file flags, command line flags - Ensure to not enable assertions when not being requested.

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -21 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/assertion_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/standalone/no_assert_test.dart	View	1 chunk	+7 lines, -11 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	2 chunks	+13 lines, -8 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

https://codereview.chromium.org/1305183010/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/1305183010/diff/1/tools/testing/dart/test_suite.dart#newcode1543 tools/testing/dart/test_suite.dart:1543: List args = []; this will not work, you ...

5 years, 3 months ago (2015-09-04 06:14:42 UTC) #3

Ivan Posva

5 years, 3 months ago (2015-09-04 19:24:56 UTC) #4

Closing this issue as it has been subsumed by
https://codereview.chromium.org/1330643003/

-Ivan

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages