Add a CreatePSS method to SignatureCreator to permit the generation of PSS signatures.

crypto/signature_creator_nss.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/signature_creator.h"
 
 #include <cryptohi.h>
 #include <keyhi.h>
 #include <stdlib.h>
 
@@ skipping 28 matching lines @@
 
 }  // namespace
 
 SignatureCreator::~SignatureCreator() {
   if (sign_context_) {
     SGN_DestroyContext(sign_context_, PR_TRUE);
     sign_context_ = NULL;
   }
 }
 
+SignatureCreator* SignatureCreator::Create(RSAPrivateKey* key,
+                                           HashAlgorithm hash_algm) {

[davidben, 2015/08/21 21:52:22]

hash_alg, to match the others?

+  return SignatureCreator::CreateImpl(key, hash_algm, false);
+}
+
+SignatureCreator* SignatureCreator::CreatePSS(RSAPrivateKey* key,
+                                              HashAlgorithm hash_algm) {
+  return SignatureCreator::CreateImpl(key, hash_algm, true);
+}
+
 // static
-SignatureCreator* SignatureCreator::Create(RSAPrivateKey* key,
-                                           HashAlgorithm hash_alg) {
+SignatureCreator* SignatureCreator::CreateImpl(RSAPrivateKey* key,
+                                               HashAlgorithm hash_alg,
+                                               bool use_pss) {
+  if (use_pss) {
+    // TODO(rch): make this work :>
+    NOTREACHED();
+    return NULL;

[davidben, 2015/08/21 21:52:22]

Pfft. Judging by crypto/signature_verifier_nss.cc, it seems to be a mess. Though
perhaps now that we can assume the bundled NSS for this file, this can be
simpler. I'll defer that to Ryan.

+  }
   scoped_ptr<SignatureCreator> result(new SignatureCreator);
   result->sign_context_ = SGN_NewContext(ToNSSSigOid(hash_alg), key->key());
   if (!result->sign_context_) {
     NOTREACHED();
     return NULL;
   }
 
   SECStatus rv = SGN_Begin(result->sign_context_);
   if (rv != SECSuccess) {
     NOTREACHED();
@@ skipping 47 matching lines @@
                     signature_item.data + signature_item.len);
   SECITEM_FreeItem(&signature_item, PR_FALSE);
   return true;
 }
 
 SignatureCreator::SignatureCreator() : sign_context_(NULL) {
   EnsureNSSInit();
 }
 
 }  // namespace crypto