Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1305163010: Fixing bug in ethersuggest (Closed)

Created:
5 years, 3 months ago by Ashok vardhan
Modified:
5 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ethersuggest++ stopped working on CR44. https://codereview.chromium.org/1189033002/patch/20001/30002 made the change in such a way that current URL is not sent to GWS. More details can be found in the bug. BUG=529447 Committed: https://crrev.com/830d6fad89e86dea88c332ba796b1db07dbf8f25 Cr-Commit-Position: refs/heads/master@{#347852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/omnibox/browser/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
LGTM
5 years, 3 months ago (2015-09-08 22:28:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305163010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305163010/1
5 years, 3 months ago (2015-09-08 22:56:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 01:00:05 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 01:00:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/830d6fad89e86dea88c332ba796b1db07dbf8f25
Cr-Commit-Position: refs/heads/master@{#347852}

Powered by Google App Engine
This is Rietveld 408576698