Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1305163009: Fix integration test failure caused by issue/1303993003. (Closed)

Created:
5 years, 3 months ago by Lei Lei
Modified:
5 years, 3 months ago
Reviewers:
imcheng, apacible, Kevin M
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix integration test failure caused by issue/1303993003. issue/1303993003 renames Media Router route "title" field to "description". BUG= Committed: https://crrev.com/545cbc7decb898d73ae81a53c35c221fc9910ebf Cr-Commit-Position: refs/heads/master@{#347881}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Jennifer's comments #

Patch Set 3 : Change 'title' to 'description' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/test/media_router/media_router_integration_ui_browsertest.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Lei Lei
5 years, 3 months ago (2015-09-08 21:37:35 UTC) #2
apacible
https://codereview.chromium.org/1305163009/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1305163009/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc#newcode36 chrome/test/media_router/media_router_integration_ui_browsertest.cc:36: std::string route_title = ExecuteScriptAndExtractString( Update title to description here ...
5 years, 3 months ago (2015-09-08 23:48:53 UTC) #3
Lei Lei
https://codereview.chromium.org/1305163009/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1305163009/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc#newcode36 chrome/test/media_router/media_router_integration_ui_browsertest.cc:36: std::string route_title = ExecuteScriptAndExtractString( On 2015/09/08 23:48:53, apacible wrote: ...
5 years, 3 months ago (2015-09-08 23:55:03 UTC) #4
imcheng
lgtm
5 years, 3 months ago (2015-09-09 00:05:02 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305163009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305163009/40001
5 years, 3 months ago (2015-09-09 00:07:59 UTC) #8
apacible
lgtm, thanks!
5 years, 3 months ago (2015-09-09 00:21:13 UTC) #9
Kevin M
lgtm
5 years, 3 months ago (2015-09-09 00:43:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305163009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305163009/40001
5 years, 3 months ago (2015-09-09 03:07:40 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-09 09:13:36 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:14:48 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/545cbc7decb898d73ae81a53c35c221fc9910ebf
Cr-Commit-Position: refs/heads/master@{#347881}

Powered by Google App Engine
This is Rietveld 408576698