Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1305163007: [heap] Remove raw unchecked root set accessors. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove raw unchecked root set accessors. R=hpayer@chromium.org BUG=v8:1490 LOG=n Committed: https://crrev.com/e276f5d89e2460dee1d5d925635622fbdb8580c2 Cr-Commit-Position: refs/heads/master@{#30412}

Patch Set 1 #

Patch Set 2 : Fix no-snap builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-27 13:19:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305163007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305163007/20001
5 years, 3 months ago (2015-08-27 13:23:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-27 13:23:27 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-08-27 13:23:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305163007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305163007/20001
5 years, 3 months ago (2015-08-27 13:44:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 13:57:44 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 13:58:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e276f5d89e2460dee1d5d925635622fbdb8580c2
Cr-Commit-Position: refs/heads/master@{#30412}

Powered by Google App Engine
This is Rietveld 408576698