Add CHROMIUM_ycbcr_422_image extension.

Add CHROMIUM_ycbcr_422_image extension.

Add an extension that provides a method for GL to process images that
are defined in '2vuy' video format.

GL_YCRCR_422_CHROMIUM <internalformat> as been added and it is an accepted
value when creating an image if the extension is supported.

This extension maps to GL_APPLE_ycbcr_422 and will allow us to determine if
we can use IOSurfaces with that format.

BUG=524582
Committed: https://crrev.com/a93c58151c01a8ccc6d98697f04c851f8992ef92
Cr-Commit-Position: refs/heads/master@{#345693}

[Daniele Castagna, 2015-08-26 17:45:31]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[Daniele Castagna, 2015-08-26 17:45:31]

PTAL

[reveman, 2015-08-26 18:21:09]

https://codereview.chromium.org/1305153005/diff/1/gpu/GLES2/extensions/CHROMI...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/GLES2/extensions/CHROMI...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt:40:
GL_YCRCR_422_CHROMIUM 0x78FB
GL_RGB_YCRCR_422_CHROMIUM

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/common/c...
File gpu/command_buffer/common/capabilities.h (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/common/c...
gpu/command_buffer/common/capabilities.h:135: bool ycbcr_422_format;
nit: texture_ycbcr_422 to be consistent with texture_rg. or maybe
image_ycbcr_422 if only used with images

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:794:
AddExtensionString("GL_CHROMIUM_ycbcr_image");
Should be CHROMIUM_ycbcr_422_image based on the spec file you're adding.

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:796:
extensions.Contains("GL_CHROMIUM_ycbcr_image");
CHROMIUM_ycbcr_422_image

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.h (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.h:82: bool ext_ycbcr_422_format;
chromium_texture_ycbcr_422 or chromium_image_ycbcr_422 (this is not an EXT
extension) to be consistent with ext_texture_rg

https://codereview.chromium.org/1305153005/diff/1/ui/gl/gl_bindings.h
File ui/gl/gl_bindings.h (right):

https://codereview.chromium.org/1305153005/diff/1/ui/gl/gl_bindings.h#newcode143
ui/gl/gl_bindings.h:143: #define GL_RGB_YCRCR_422_CHROMIUM 0x78FB
nit: align 0x78FB with 0x78FA

[Daniele Castagna, 2015-08-26 18:40:08]

https://codereview.chromium.org/1305153005/diff/1/gpu/GLES2/extensions/CHROMI...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/GLES2/extensions/CHROMI...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt:40:
GL_YCRCR_422_CHROMIUM 0x78FB
On 2015/08/26 at 18:21:08, reveman wrote:
> GL_RGB_YCRCR_422_CHROMIUM

Done.

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/common/c...
File gpu/command_buffer/common/capabilities.h (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/common/c...
gpu/command_buffer/common/capabilities.h:135: bool ycbcr_422_format;
On 2015/08/26 at 18:21:08, reveman wrote:
> nit: texture_ycbcr_422 to be consistent with texture_rg. or maybe
image_ycbcr_422 if only used with images

Renamed to |image_ycbcr_422| as discussed IRL.

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:794:
AddExtensionString("GL_CHROMIUM_ycbcr_image");
On 2015/08/26 at 18:21:08, reveman wrote:
> Should be CHROMIUM_ycbcr_422_image based on the spec file you're adding.

Done.

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:796:
extensions.Contains("GL_CHROMIUM_ycbcr_image");
On 2015/08/26 at 18:21:08, reveman wrote:
> CHROMIUM_ycbcr_422_image

Done.

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.h (right):

https://codereview.chromium.org/1305153005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.h:82: bool ext_ycbcr_422_format;
On 2015/08/26 at 18:21:08, reveman wrote:
> chromium_texture_ycbcr_422 or chromium_image_ycbcr_422 (this is not an EXT
extension) to be consistent with ext_texture_rg

Renamed to |chromium_image_ycbcr_422|.

[reveman, 2015-08-26 18:47:10]

lgtm after fixing unit test

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info_unittest.cc (right):

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:1366:
TEST_P(FeatureInfoTest, InitializeEXT_ycbcr_422True) {
InitializeCHROMIUM_ycbcr_422_imageTrue

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:1368:
EXPECT_TRUE(info_->feature_flags().ext_ycbcr_422_format);
.chromium_image_ycbcr_422

[Daniele Castagna, 2015-08-26 18:51:38]

Patchset #3 (id:40001) has been deleted

[Daniele Castagna, 2015-08-26 18:53:17]

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info_unittest.cc (right):

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:1366:
TEST_P(FeatureInfoTest, InitializeEXT_ycbcr_422True) {
On 2015/08/26 at 18:47:10, reveman wrote:
> InitializeCHROMIUM_ycbcr_422_imageTrue

Done.

https://codereview.chromium.org/1305153005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:1368:
EXPECT_TRUE(info_->feature_flags().ext_ycbcr_422_format);
On 2015/08/26 at 18:47:10, reveman wrote:
> .chromium_image_ycbcr_422

Done.

[Daniele Castagna, 2015-08-26 18:57:49]

dcastagna@chromium.org changed reviewers:
+ sievers@chromium.org

[Daniele Castagna, 2015-08-26 18:57:49]

+sievers for owner approval.

[no sievers, 2015-08-26 19:20:44]

Shouldn't it be called GL_RGB_YCBCR_422_CHROMIUM?
                                ^

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:795:
feature_flags_.chromium_image_ycbcr_422 =
nit: just put it in the if-block instead of parsing the extensions again

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info_unittest.cc (right):

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:295:
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
 EXPECT_FALSE(info_->feature_flags().chromium_image_ycbcr_422)

[Daniele Castagna, 2015-08-26 19:41:16]

On 2015/08/26 at 19:20:44, sievers wrote:
> Shouldn't it be called GL_RGB_YCBCR_422_CHROMIUM?
>                                 ^
> 

It should. Fixed it. :)

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:795:
feature_flags_.chromium_image_ycbcr_422 =
On 2015/08/26 at 19:20:44, sievers wrote:
> nit: just put it in the if-block instead of parsing the extensions again

Done.

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info_unittest.cc (right):

https://codereview.chromium.org/1305153005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info_unittest.cc:295:
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
On 2015/08/26 at 19:20:44, sievers wrote:
> EXPECT_FALSE(info_->feature_flags().chromium_image_ycbcr_422)

Done.

[no sievers, 2015-08-26 19:52:10]

lgtm

[Daniele Castagna, 2015-08-26 19:58:34]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2015-08-26 19:58:34]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1305153005/#ps80001
(title: "Address sievers' comments.")

[commit-bot: I haz the power, 2015-08-26 19:59:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305153005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305153005/80001

[commit-bot: I haz the power, 2015-08-26 22:08:40]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-08-26 22:09:17]

Patchset 4 (id:??) landed as
https://crrev.com/a93c58151c01a8ccc6d98697f04c851f8992ef92
Cr-Commit-Position: refs/heads/master@{#345693}