Chromium Code Reviews| Index: chrome/browser/ui/views/find_bar_views_interactive_uitest.cc |
| diff --git a/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc b/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc |
| index 904fec606817c594ae58708904fb07bedd979a3f..52987e0e143a64aea8cfb1103506112f3f83c0d4 100644 |
| --- a/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc |
| +++ b/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc |
| @@ -90,6 +90,48 @@ IN_PROC_BROWSER_TEST_F(FindInPageTest, CrashEscHandlers) { |
| browser(), ui::VKEY_ESCAPE, false, false, false, false)); |
| } |
| +IN_PROC_BROWSER_TEST_F(FindInPageTest, NavigationByKeyEvent) { |
| + ASSERT_TRUE(test_server()->Start()); |
| + // Make sure Chrome is in the foreground, otherwise sending input |
| + // won't do anything and the test will hang. |
| + ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser())); |
| + // First we navigate to any page. |
| + ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(kSimplePage)); |
| + // Show the Find bar. |
| + chrome::FocusLocationBar(browser()); |
|
msw
2015/08/27 18:09:02
Remove this unnecessary step, as I previously aske
Deepak
2015/08/28 04:20:21
Done.
|
| + EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX)); |
|
msw
2015/08/27 18:09:02
Remove this unnecessary step, as I previously aske
Deepak
2015/08/28 04:20:20
Done.
|
| + // Ensure the creation of the find bar controller. |
|
msw
2015/08/27 18:09:02
Remove this comment (redundant with the one on lin
Deepak
2015/08/28 04:20:20
Done.
|
| + browser()->GetFindBarController()->Show(); |
| + EXPECT_TRUE( |
| + ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)); |
| + ui_test_utils::FindInPage( |
| + browser()->tab_strip_model()->GetActiveWebContents(), ASCIIToUTF16("a"), |
| + true, false, NULL, NULL); |
| + |
| + // Verifying that TextField will get focused when we select Enter key with |
|
msw
2015/08/27 18:09:02
nit: "// The textfield should be focused after pre
Deepak
2015/08/28 04:20:20
Done.
|
| + // '/\' button focused in find bar. |
| + ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false, |
| + false, false, false)); |
| + ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_RETURN, false, |
| + false, false, false)); |
| + EXPECT_TRUE( |
| + ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)); |
| + |
| + // Verifying that TextField will get focused when we select Enter key with |
|
msw
2015/08/27 18:09:02
ditto nit: "// The textfield should be focused aft
Deepak
2015/08/28 04:20:20
Done.
|
| + // '\/' button focused in find bar. |
| + ui_test_utils::FindInPage( |
| + browser()->tab_strip_model()->GetActiveWebContents(), ASCIIToUTF16("b"), |
| + true, false, NULL, NULL); |
| + ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false, |
| + false, false, false)); |
| + ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false, |
| + false, false, false)); |
| + ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_RETURN, false, |
| + false, false, false)); |
| + EXPECT_TRUE( |
| + ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)); |
| +} |
| + |
| #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) |
| // TODO(erg): linux_aura bringup: http://crbug.com/163931 |
| #define MAYBE_FocusRestore DISABLED_FocusRestore |