Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 776e2033d5f138cd7388f0b09a70770fbc831dc5..a9642e2d0058ea8139f6c382f34774cb2a77b3de 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -326,6 +326,7 @@ using content::WebContents;
browser:browser]);
[toolbarController_ setHasToolbar:[self hasToolbar]
hasLocationBar:[self hasLocationBar]];
+ shouldShowToolbar_ = YES;
// Create a sub-controller for the bookmark bar.
bookmarkBarController_.reset(
@@ -407,6 +408,18 @@ using content::WebContents;
name:NSApplicationDidUnhideNotification
object:nil];
+ // Register for toolbar visibility notifications from LocationBarViewMac.
+ [[NSNotificationCenter defaultCenter]
+ addObserver:self
+ selector:@selector(showToolbar:)
+ name:chrome::kShowToolbarNotification
+ object:nil];
+ [[NSNotificationCenter defaultCenter]
+ addObserver:self
+ selector:@selector(hideToolbar:)
+ name:chrome::kHideToolbarNotification
+ object:nil];
+
// This must be done after the view is added to the window since it relies
// on the window bounds to determine whether to show buttons or not.
if ([self hasToolbar]) // Do not create the buttons in popups.

Powered by Google App Engine
This is Rietveld 408576698