[Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

chrome/browser/ui/cocoa/browser_window_layout.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_LAYOUT_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_LAYOUT_H_
 
 #import <Cocoa/Cocoa.h>
 
 #import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
@@ skipping 33 matching lines @@
   BOOL shouldShowAvatar;
   // Whether to use the new avatar button. Only needs to be set when
   // shouldShowAvatar is YES.
   BOOL shouldUseNewAvatar;
   // The size of the avatar button. Only needs to be set when shouldShowAvatar
   // is YES.
   NSSize avatarSize;
   // The line width that will generate a 1 pixel wide line for the avatar's
   // superview. Only needs to be set when shouldShowAvatar is YES.
   CGFloat avatarLineWidth;
 

[tapted, 2015/10/12 23:56:43]

nit: remove newline

+  // Hosted apps hide and show the toolbar (location bar) independently of
+  // whether it is available as a browser feature.
+  BOOL toolbarHidden;

[tapted, 2015/10/12 23:56:43]

nit: newline after (otherwise it looks like the comment applies to all 3 params)

[tapted, 2015/10/13 00:00:19]

Also, maybe this can be obsoleted by setting toolbarHeight below to 0?

(perhaps it should be called `targetToolbarHeight` in that case... in which case
it could perhaps also make LocationBarViewMac::visible_ obsolete? -- i.e. it
would be nicer to derive LocationBarViewMac::visible_ rather than cache it)

[dominickn, 2015/10/15 06:22:28]

Changes discarded.

   BOOL hasToolbar;
   BOOL hasLocationBar;
   CGFloat toolbarHeight;
 
   BOOL bookmarkBarHidden;
   // If the bookmark bar is not hidden, then the bookmark bar should either be
   // directly below the omnibox, or directly below the info bar. This parameter
   // selects between those 2 cases.
   BOOL placeBookmarkBarBelowInfoBar;
   CGFloat bookmarkBarHeight;
@@ skipping 87 matching lines @@
 - (void)setFullscreenMenubarOffset:(CGFloat)menubarOffset;
 - (void)setFullscreenToolbarFraction:(CGFloat)toolbarFraction;
 
 - (void)setHasTabStrip:(BOOL)hasTabStrip;
 - (void)setFullscreenButtonFrame:(NSRect)frame;
 - (void)setShouldShowAvatar:(BOOL)shouldShowAvatar;
 - (void)setShouldUseNewAvatar:(BOOL)shouldUseNewAvatar;
 - (void)setAvatarSize:(NSSize)avatarSize;
 - (void)setAvatarLineWidth:(CGFloat)avatarLineWidth;
 
+- (void)setToolbarHidden:(BOOL)toolbarHidden;
 - (void)setHasToolbar:(BOOL)hasToolbar;
 - (void)setHasLocationBar:(BOOL)hasLocationBar;
 - (void)setToolbarHeight:(CGFloat)toolbarHeight;
 
 - (void)setBookmarkBarHidden:(BOOL)bookmarkBarHidden;
 - (void)setPlaceBookmarkBarBelowInfoBar:(BOOL)placeBookmarkBarBelowInfoBar;
 - (void)setBookmarkBarHeight:(CGFloat)bookmarkBarHeight;
 
 // The height of the info bar, not including the top arrow.
 - (void)setInfoBarHeight:(CGFloat)infoBarHeight;
 // The min Y of the bubble point, relative to the toolbar.
 - (void)setPageInfoBubblePointY:(CGFloat)pageInfoBubblePointY;
 
 - (void)setHasDownloadShelf:(BOOL)hasDownloadShelf;
 - (void)setDownloadShelfHeight:(CGFloat)downloadShelfHeight;
 @end
 
 @interface BrowserWindowLayout (ExposedForTesting)
 - (void)setOSYosemiteOrLater:(BOOL)osYosemiteOrLater;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_LAYOUT_H_