[Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
@@ skipping 64 matching lines @@
   // Lazily-instantiated menu controller.
   base::scoped_nsobject<WrenchMenuController> wrenchMenuController_;
 
   // Used for monitoring the optional toolbar button prefs.
   scoped_ptr<ToolbarControllerInternal::NotificationBridge> notificationBridge_;
   BooleanPrefMember showHomeButton_;
   BOOL hasToolbar_;  // If NO, we may have only the location bar.
   BOOL hasLocationBar_;  // If |hasToolbar_| is YES, this must also be YES.
   BOOL locationBarAtMinSize_; // If the location bar is at the minimum size.
 
-  // We have an extra retain in the locationBar_.
-  // See comments in awakeFromNib for more info.
-  base::scoped_nsobject<AutocompleteTextField> locationBarRetainer_;
-
   // Tracking area for mouse enter/exit/moved in the toolbar.
   ui::ScopedCrTrackingArea trackingArea_;
 
   // We retain/release the hover button since interaction with the
   // button may make it go away (e.g. delete menu option over a
   // bookmark button).  Thus this variable is not weak.  The
   // hoveredButton_ is required to have an NSCell that responds to
   // setMouseInside:animate:.
   NSButton* hoveredButton_;
 }
 
 // Initialize the toolbar and register for command updates. The profile is
 // needed for initializing the location bar. The browser is needed for
-// the toolbar model and back/forward menus.
+// the toolbar model and back/forward menus. The resizeDelegate is used
+// to smoothly animate height changes for the toolbar.
 - (id)initWithCommands:(CommandUpdater*)commands
                profile:(Profile*)profile
-               browser:(Browser*)browser;
+               browser:(Browser*)browser
+        resizeDelegate:(id<ViewResizer>)resizeDelegate;
 
 // Get the C++ bridge object representing the location bar for this tab.
 - (LocationBarViewMac*)locationBarBridge;
 
 // Called by the Window delegate so we can provide a custom field editor if
 // needed.
 // Note that this may be called for objects unrelated to the toolbar.
 // returns nil if we don't want to override the custom field editor for |obj|.
 - (id)customFieldEditorForObject:(id)obj;
 
@@ skipping 44 matching lines @@
 // Returns the desired toolbar height for the given compression factor.
 - (CGFloat)desiredHeightForCompression:(CGFloat)compressByHeight;
 
 // Set the opacity of the divider (the line at the bottom) *if* we have a
 // |ToolbarView| (0 means don't show it); no-op otherwise.
 - (void)setDividerOpacity:(CGFloat)opacity;
 
 // Create and add the Browser Action buttons to the toolbar view.
 - (void)createBrowserActionButtons;
 
+// Updates the visibility of the toolbar if the requested visibility differs
+// from the current visibility, with an optional animation.
+- (void)updateVisibility:(BOOL)visible withAnimation:(BOOL)animate;
+
+// Hide the back, forward, reload, home, and wrench buttons of the toolbar,

[tapted, 2015/10/20 06:31:08]

nit: no comma after `toolbar,`. Or a new sentence, e.g. This allows the location
bar to occupy

[dominickn, 2015/10/26 02:53:04]

Done.

+// so that the location bar occupies the entire width. There is no way to
+// undo this operation, and once it is called, no other modifications to
+// the toolbar or location bar width should be made.

[tapted, 2015/10/20 06:31:08]

what if the window is resized?

[dominickn, 2015/10/26 02:53:04]

That *just works*. Have updated the comment.

+- (void)showLocationBarOnly;

[tapted, 2015/10/20 06:31:09]

move this declaration to `@interface ToolbarController()` in the .mm file (and
reorder method definitions to match)

[dominickn, 2015/10/26 02:53:04]

Done.

+
 // Return the BrowserActionsController for this toolbar.
 - (BrowserActionsController*)browserActionsController;
 
 // Returns the wrench button.
 - (NSButton*)wrenchButton;
 
 // Returns the wrench menu controller.
 - (WrenchMenuController*)wrenchMenuController;
 
 @end
 
 // A set of private methods used by subclasses. Do not call these directly

[tapted, 2015/10/20 06:31:08]

This comment seems out of date... (pretty sure nothing calls this from a
subclass, otherwise stuff would have broke)

I think this declaration and the other methods definiton can be removed, remove
the `nibFileNamed` argument in the overload's definition, and substitute nibName
with the @"Toolbar" string literal.

[dominickn, 2015/10/26 02:53:04]

Done.

 // unless a subclass of ToolbarController.
 @interface ToolbarController(ProtectedMethods)
 // Designated initializer which takes a nib name in order to allow subclasses
 // to load a different nib file.
 - (id)initWithCommands:(CommandUpdater*)commands
                profile:(Profile*)profile
                browser:(Browser*)browser
+        resizeDelegate:(id<ViewResizer>)resizeDelegate
           nibFileNamed:(NSString*)nibName;
 @end
 
 // A set of private methods used by tests, in the absence of "friends" in ObjC.
 @interface ToolbarController(PrivateTestMethods)
 // Returns an array of views in the order of the outlets above.
 - (NSArray*)toolbarViews;
 - (void)showOptionalHomeButton;
 - (void)installWrenchMenu;
 // Return a hover button for the current event.
 - (NSButton*)hoverButtonForEvent:(NSEvent*)theEvent;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_