Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: include/codec/SkScanlineDecoder.h

Issue 1305123002: Scanline decoding for gifs (Closed) Base URL: https://skia.googlesource.com/skia.git@real-bmp-scan
Patch Set: Make kScanline_Mode test kOutOfOrder correctly in dm Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/codec/SkScanlineDecoder.h
diff --git a/include/codec/SkScanlineDecoder.h b/include/codec/SkScanlineDecoder.h
index 61184d644a15d9043e2fef92f3aa1e54a01e21e8..34c66c95f8dd014290ccb6ccd1fbd9f3ab5dcba1 100644
--- a/include/codec/SkScanlineDecoder.h
+++ b/include/codec/SkScanlineDecoder.h
@@ -215,7 +215,9 @@ public:
/**
* An enum representing the order in which scanlines will be returned by
- * the scanline decoder.
+ * the scanline decoder. This should not be called until after we have
+ * called start(). Specifically, we do not know if gifs are interlaced
scroggo 2015/09/02 22:45:48 From your comments elsewhere, it sounded like it s
msarett 2015/09/03 17:13:30 I'm happy add more to ReadHeader(). I agree that
scroggo 2015/09/04 18:42:09 We might have decided on that, but I think I did n
+ * until after the call to start().
*/
SkScanlineOrder getScanlineOrder() const { return this->onGetScanlineOrder(); }

Powered by Google App Engine
This is Rietveld 408576698